Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Features] Create project as SVPC host project #465

Merged
merged 8 commits into from
Oct 2, 2020
Merged

[Features] Create project as SVPC host project #465

merged 8 commits into from
Oct 2, 2020

Conversation

thiagonache
Copy link
Contributor

@morgante @bharathkkb After two PRs (#459 and #464) I hope I finally did the right thing 😅

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one final request - please expose the enable_shared_vpc_host_project on the gsuite submodule.

@thiagonache thiagonache requested a review from morgante October 2, 2020 16:54
@morgante morgante merged commit 3b269be into terraform-google-modules:master Oct 2, 2020
@morgante
Copy link
Contributor

morgante commented Oct 2, 2020

@thiagonache Thank you for the contribution and patience with all the back-and-forth.

@thiagonache
Copy link
Contributor Author

@thiagonache Thank you for the contribution and patience with all the back-and-forth.

🥳
Thank you for your patience to explain how the modules interact with each other. Now, I feel I understand it better :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants