Create project as host project (shared_vpc_host)

[thiagonache]

Hi @morgante @bharathkkb ,

After a lot of discussions, I'm opening a new PR with a clean branch. I hope all is correct now.

[morgante]

The error is here:

terraform_validate ./test/fixtures/full 

Error: Unsupported argument

  on .terraform/modules/vpc/main.tf line 58, in resource "google_compute_subnetwork" "subnetwork":
  58:   enable_flow_logs         = lookup(var.subnets[count.index], "subnet_flow_logs", "false")

An argument named "enable_flow_logs" is not expected here.

[thiagonache]

I don’t think it is related to my changes... do you?

…

On 1 Oct 2020, at 16:56, Morgante Pell ***@***.***> wrote:  The error is here: terraform_validate ./test/fixtures/full Error: Unsupported argument on .terraform/modules/vpc/main.tf line 58, in resource "google_compute_subnetwork" "subnetwork": 58: enable_flow_logs = lookup(var.subnets[count.index], "subnet_flow_logs", "false") An argument named "enable_flow_logs" is not expected here. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[thiagonache]

I don’t think it is related to my changes... do you?
…
On 1 Oct 2020, at 16:56, Morgante Pell @.***> wrote:  The error is here: terraform_validate ./test/fixtures/full Error: Unsupported argument on .terraform/modules/vpc/main.tf line 58, in resource "google_compute_subnetwork" "subnetwork": 58: enable_flow_logs = lookup(var.subnets[count.index], "subnet_flow_logs", "false") An argument named "enable_flow_logs" is not expected here. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

What I've found is that enable_flow_logs was deprecated, we should use log_config instead. Trying to match the same version that is working for me.

[thiagonache]

@morgante for some odd reason the google provider version pulled by my terraform execution end up with a different version than in the CI environment. I've deleted the terraform cache and confirmed that it pulled out the version 3.40 again, so I've created the required version config for the provider in fixtures/full/versions.tf and it worked.
The last thing I've just done is to revert the commit to pin the module version that was my initial suspicion. I'm confident that it will work this time.

[thiagonache]

yay!

[morgante]

When creating the host project you should not need a shared_vpc input variable with the name.

[thiagonache]

@morgante okay. you're right, but I think we should rename shared_vpc_enabled on the next major release as we will do with shared_vpc, do you agree?
Just finishing up to run tests locally and I will push changes

[morgante]

that's the problem with the logic and mentioned. We agreed on that...
the only way to determine the variable is if shared_vpc is set

No it's not. There is no reason to set shared_vpc on the host project—it already is the host project. Just ignore it completely. It's very confusing to pass a name to the shared_vpc argument on the host project.

[thiagonache]

that's the problem with the logic and mentioned. We agreed on that...
the only way to determine the variable is if shared_vpc is set

No it's not. There is no reason to set shared_vpc on the host project—it already is the host project. Just ignore it completely. It's very confusing to pass a name to the shared_vpc argument on the host project.

yeah... I've removed this comment. Please, see my last comment

[morgante]

@morgante okay. you're right, but I think we should rename shared_vpc_enabled on the next major release as we will do with shared_vpc, do you agree?

Yep.

[thiagonache]

Please, see related PR.