Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: rename shared_vpc submodule #517

Merged
merged 7 commits into from
Dec 15, 2020
Merged

Fix: rename shared_vpc submodule #517

merged 7 commits into from
Dec 15, 2020

Conversation

ChandranshuRao14
Copy link
Contributor

@ChandranshuRao14 ChandranshuRao14 commented Dec 15, 2020 •
edited
Loading

Fixes #463

  • Renamed shared_vpc submodule to svpc_service_project
  • Renamed var.shared_vpc to var.svpc_host_prroject_id in root module
  • Renamed var.shared_vpc_enabled to var.enable_shared_vpc_service_project everywhere

Let me know if there are any other changes that need to be included! I held off on renaming var.shared_vpc outside the root module but happy to add this change in if necessary.

@ChandranshuRao14 ChandranshuRao14 requested a review from a team as a code owner December 15, 2020 19:34
@morgante morgante merged commit 86819d7 into terraform-google-modules:master Dec 15, 2020
@bharathkkb bharathkkb mentioned this pull request Dec 19, 2020
Closed
This was referenced Aug 18, 2022
Closed
Closed
@release-please release-please bot mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename shared_vpc
2 participants
@ChandranshuRao14 @morgante