Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct SA custom name flag check in setup #418

Merged
merged 1 commit into from
May 8, 2020
Merged

fix: Correct SA custom name flag check in setup #418

merged 1 commit into from
May 8, 2020

Conversation

morgante
Copy link
Contributor

@morgante morgante commented May 8, 2020

Fixes #416

@morgante morgante requested a review from adrienthebo as a code owner May 8, 2020 17:18
@morgante morgante requested a review from bharathkkb May 8, 2020 17:45
bharathkkb
bharathkkb approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch LGTM

@morgante morgante merged commit 9da8158 into master May 8, 2020
@morgante morgante deleted the fix/setup-sa branch August 13, 2020 15:11
This was referenced Aug 18, 2022
Closed
Closed
@release-please release-please bot mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@adrienthebo adrienthebo Awaiting requested review from adrienthebo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setup-sa.sh fails "Service account name must be between 6 and 30 characters"
2 participants
@morgante @bharathkkb