Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: relax tf version to allow 0.13 #437

Merged
merged 1 commit into from
Aug 10, 2020
Merged

chore: relax tf version to allow 0.13 #437

merged 1 commit into from
Aug 10, 2020

Conversation

bharathkkb
Copy link
Member

  • relax version constraint to allow usage with 0.13
  • Kitchen tests run with v0.13.0-rc1
    • minimal-local, fabric-project-local, app-engine-local, budget-local passed
    • vpc-sc-project-local, dynamic_shared_vpc failed due to dependencies on other modules with version constraints
  • module for_each and depends_on spot checked and seems to be working without issues

@bharathkkb bharathkkb requested a review from a team August 9, 2020 19:48
@bharathkkb
Copy link
Member Author

build 79664f37-0e0f-497f-9b2d-8d5d977e3a2c passed

@morgante morgante merged commit 9eb64e2 into master Aug 10, 2020
@morgante morgante deleted the relax-tf-required branch August 13, 2020 15:11
@thiagonache
Copy link
Contributor

should we revert it after issues reported?

@morgante
Copy link
Contributor

morgante commented Nov 4, 2020

@thiagonache Which issues are you referring to?

@thiagonache
Copy link
Contributor

These two #487 and #482

@morgante
Copy link
Contributor

morgante commented Nov 4, 2020

Those weren't introduced by this change, so no need to revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants