-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add force_destroy option to GCS bucket #545
Merged
morgante
merged 6 commits into
terraform-google-modules:master
from
andrewmackett:master
Mar 30, 2021
Merged
Add force_destroy option to GCS bucket #545
morgante
merged 6 commits into
terraform-google-modules:master
from
andrewmackett:master
Mar 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the PR! 🚀 |
morgante
suggested changes
Feb 16, 2021
hi, any updates on when this will be implemented? |
@vital4ik Awaiting response to my feedback by @andrewmackett. |
thank you, @andrewmackett anxiously waiting, since will fix a lot of issues and workarounds in purging buckets ! |
Hi @morgante, do you know when this is going to be released? |
morgante
approved these changes
Mar 30, 2021
@andrewmackett Please also add this to the g suite and other submodules. |
This was referenced Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a
bucket_force_destroy
variable to allowterraform destroy
to be run on this module more gracefully.At the moment if any objects are left in the GCS bucket, running terraform destroy results in an error:
The default value of the new variable is false, so there is no change in functionality without setting
bucket_force_destroy
to true.