Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force_destroy option to GCS bucket #545

Merged
merged 6 commits into from
Mar 30, 2021
Merged

Add force_destroy option to GCS bucket #545

merged 6 commits into from
Mar 30, 2021

Conversation

andrewmackett
Copy link
Contributor

Adding a bucket_force_destroy variable to allow terraform destroy to be run on this module more gracefully.

At the moment if any objects are left in the GCS bucket, running terraform destroy results in an error:

Error: Error trying to delete bucket <bucket name> containing objects without `force_destroy` set to true

The default value of the new variable is false, so there is no change in functionality without setting bucket_force_destroy to true.

@comment-bot-dev
Copy link

comment-bot-dev commented Feb 15, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

@vital4ik
Copy link

hi, any updates on when this will be implemented?

@morgante
Copy link
Contributor

@vital4ik Awaiting response to my feedback by @andrewmackett.

@vital4ik
Copy link

thank you, @andrewmackett anxiously waiting, since will fix a lot of issues and workarounds in purging buckets !

@vital4ik
Copy link

Hi @morgante, do you know when this is going to be released?

@morgante
Copy link
Contributor

@andrewmackett Please also add this to the g suite and other submodules.

@morgante morgante merged commit 1774999 into terraform-google-modules:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants