refactor: added additional prefix validation

[kierramarie]

Description

Added additional prefix validation to check more than length.

GIT Issue: #770

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[kierramarie]

/run pipeline

[kierramarie]

/run pipeline

[kierramarie]

/run pipeline

[kierramarie]

/run pipeline

[kierramarie]

/run pipeline

[kierramarie]

/run pipeline

.

[kierramarie]

/run pipeline

[shemau]

Would it be neater

    condition = anytrue([
      var.prefix == null,
      can(regex("^([a-z]|[a-z][-a-z0-9]{0,14}[a-z0-9])$", var.prefix))
    ])

Either
null

the regex is
a single lower letter,
or,
a single lower letter, ending in letter or number with 0 to 14 characters (making 16 total) in the middle.

This avoids the coalesce commands with an arbitrary string and the need for a specific length validation

[shemau]

Two adjacent '-'s are also not permitted.

  validation {
  condition = anytrue([
      var.prefix == null,
      alltrue([
        can(regex("^([a-z]|[a-z][-a-z0-9]{0,14}[a-z0-9])$", var.prefix)),
        length(regexall("^.*--.*", var.prefix)) == 0
      ])
    ])
    error_message = "Prefix must begin with a lowercase letter, contain only lowercase letters, numbers, and - characters. Prefixes must end with a lowercase letter or number and be 16 or fewer characters."
  }

[shemau]

Very brief discussion in the standup today. Decided this should be a request changes response.