-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aws_security_group_rule_invalid_protocol rule #355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I left 2 suggestions, but I believe this rule is useful.
"tcp": {}, | ||
"udp": {}, | ||
"icmp": {}, | ||
"icmpv6": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,33 @@ | |||
# aws_security_group_rule_invalid_protocol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a link to this rule in README.md.tmpl
. I think this rule is categorized as possible errors.
https://github.com/terraform-linters/tflint-ruleset-aws/blob/45cd608fd65235483faa57caa1da9024feb99f1e/docs/rules/README.md.tmpl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it. 894fbfe
Thanks! |
Add
aws_security_group_rule_invalid_protocol
rule.This rule checks whether
protocol
has an invalid value as protocol.