Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws_security_group_rule_invalid_protocol rule #355

Merged
merged 3 commits into from
Jul 14, 2022

Conversation

x-color
Copy link
Member

@x-color x-color commented Jul 10, 2022

Add aws_security_group_rule_invalid_protocol rule.

This rule checks whether protocol has an invalid value as protocol.

Copy link
Member

@wata727 wata727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I left 2 suggestions, but I believe this rule is useful.

"tcp": {},
"udp": {},
"icmp": {},
"icmpv6": {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@x-color x-color Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wata727
Thank you for reviewing my PR!
I fixed it. e050a3c

@@ -0,0 +1,33 @@
# aws_security_group_rule_invalid_protocol
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to this rule in README.md.tmpl. I think this rule is categorized as possible errors.
https://github.com/terraform-linters/tflint-ruleset-aws/blob/45cd608fd65235483faa57caa1da9024feb99f1e/docs/rules/README.md.tmpl

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it. 894fbfe

@wata727 wata727 merged commit fdc5acc into terraform-linters:master Jul 14, 2022
@wata727
Copy link
Member

wata727 commented Jul 14, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants