Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: remove loop variable copying #2044

Merged
merged 2 commits into from
May 7, 2024
Merged

go: remove loop variable copying #2044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f84008d
go: remove loop variable copying
bendrucker May 7, 2024
4834ba7
Merge branch 'master' into copyloopvar
bendrucker May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ linters:
enable:
- gci
- gofmt
- copyloopvar
issues:
exclude-dirs:
- terraform/
Expand Down
2 changes: 0 additions & 2 deletions plugin/install_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@ func TestNewGitHubClient(t *testing.T) {
}

for _, tc := range cases {
tc := tc

t.Run(tc.name, func(t *testing.T) {
client, err := newGitHubClient(context.Background(), tc.config)
if err != nil {
Expand Down
Loading