Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update thumbprints input variable to be a list with 2 items as default #46

Closed

Conversation

jreslock
Copy link

@jreslock jreslock commented Oct 2, 2023

↪️ Pull Request

  • Make sure you are opening from a feature/feat/docs/fix/bug/hotfix/stable/chore (right side) and not your master branch!
  • [N/A ??] Ensure that the pull request title represents the desired changelog entry

📒 Description

🕶️ Types of changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation
  • Dependencies

🤯 List of changes

GitHub has 2 thumbprints and the input variable should have them both as a default value.

Also fixing tflint warnings

👫 Relationships

🔎 Review hints

🚨 Test instructions

Checklist

  • My code follows the code style of this project.
  • [N/A] I have read the CONTRIBUTING document.
  • [N/A] Added/updated unit tests for this change
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).
  • [N/A] Filled out test instructions (In case there aren't any unit tests)
  • I followed the existing code standards and didn't mess up the formatting.
  • My change requires a change to the documentation.
  • [N/A] I did my best to add documentation to any public classes or methods I added.
  • [N/A] Included links to related issues/PRs

GitHub has 2 thumbprints and the input variable should have them both
as a default value.

Also fixing tflint warnings
@jreslock jreslock changed the title Update thumbprints input variable to be a list with 2 items as default Fix: Update thumbprints input variable to be a list with 2 items as default Oct 2, 2023
@jreslock jreslock changed the title Fix: Update thumbprints input variable to be a list with 2 items as default fix: Update thumbprints input variable to be a list with 2 items as default Oct 2, 2023
@jreslock
Copy link
Author

jreslock commented Oct 2, 2023

This is a duplicate of #35

@jreslock jreslock closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant