Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing documented 'oidc_provider_arn' variable. #53

Merged

Conversation

fabienduhamel
Copy link
Contributor

πŸ“’ Description

I added the ability to provide an external oidc_provider_arn as shown in the README but not implemented yet.

πŸ•ΆοΈ Types of changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation
  • Dependencies

πŸ”Ž Review hints

You can use the module separately to check the feature:

  • one usage of the module with create_oidc_provider = true
  • one usage of the module with create_oidc_provider = false and oidc_provider_arn = module.<previous_usage>.oidc_provider_arn

🚨 Test instructions

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • Added/updated unit tests for this change
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).
  • Filled out test instructions (In case there aren't any unit tests)
  • I followed the existing code standards and didn't mess up the formatting.
  • My change requires a change to the documentation.
  • I did my best to add documentation to any public classes or methods I added.
  • Included links to related issues/PRs

@fabienduhamel fabienduhamel changed the title Fixed missing documented 'oidc_provider_arn' variable fix: missing documented 'oidc_provider_arn' variable. Jan 15, 2024
@shaafekhan
Copy link

Hi there. Any news on this pull request? what's the status? thank you.

@ivankatliarchuk ivankatliarchuk merged commit 9fb3e66 into terraform-module:master Mar 23, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants