updated with latest redshift service account ID's #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ninir
reviewed
Sep 7, 2017
| @@ -33,6 +33,6 @@ data "aws_redshift_service_account" "main" { } | |||
|
|
|||
| const testAccCheckAwsRedshiftServiceAccountExplicitRegionConfig = ` | |||
| data "aws_redshift_service_account" "regional" { | |||
| region = "eu-west-1" | |||
| region = "eu-west-2" | |||
There was a problem hiding this comment.
Is there a reason to change this test?
There was a problem hiding this comment.
Possibly not - I'm new to updating the terraform source code
I thought it would help validate the new Redshift service account (eu-west-2) being added - remove if not required
There was a problem hiding this comment.
No worries, was just wondering :)
Ninir
added
the
enhancement
Ninir
approved these changes
Sep 7, 2017
There was a problem hiding this comment.
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSRedshiftServiceAccount_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSRedshiftServiceAccount_basic -timeout 120m
=== RUN TestAccAWSRedshiftServiceAccount_basic
--- PASS: TestAccAWSRedshiftServiceAccount_basic (58.93s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 58.968s
LGTM, thanks again @david-wells-1 ! 👍
nbaztec
pushed a commit
to nbaztec/terraform-provider-aws
that referenced
this pull request
Sep 26, 2017
updated with latest redshift service account ID's
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS Redshift service accounts IDs added to included newest regions where Redshift is now supported
Documentation: http://docs.aws.amazon.com/fr_fr/redshift/latest/mgmt/db-auditing.html