-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data_source_aws_security_group: add description #1943
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @darkowlzz
This looks good! 👍
Just left a nitpick. Also, can you ad the attribute in the documentation? would help people knows this exists.
Thanks!
|
||
"description": { | ||
Type: schema.TypeString, | ||
Optional: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional is used when the user can pass a value for this attribute. Since we are only retrieving the description (and we don't need it to retrieve the Security Group info), this is not needed here and can be removed
b941b70
to
e82313f
Compare
@Ninir thanks for the review. Removed About adding the attribute to documentation, isn't it already there in the docs? https://github.com/terraform-providers/terraform-provider-aws/blob/master/website/docs/d/security_group.html.markdown#attributes-reference Should I add it to some other docs too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot @darkowlzz! 👍
$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsSecurityGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsSecurityGroup -timeout 120m
=== RUN TestAccDataSourceAwsSecurityGroup
--- PASS: TestAccDataSourceAwsSecurityGroup (22.36s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 22.391s
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
From #1940 I came across https://www.terraform.io/docs/providers/aws/d/security_group.html#description where
description
is an attribute reference. But in real,description
isn't available. This change addsdescription
todata_source_aws_security_group
.This doesn't f-ixes #1940, which talks about description for the SG rules, which I see already exist 🤷♀️.