Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_mq_broker: validate user password #3164

Merged
merged 2 commits into from
Jan 29, 2018
Merged

resource/aws_mq_broker: validate user password #3164

merged 2 commits into from
Jan 29, 2018

Conversation

loivis
Copy link
Contributor

@loivis loivis commented Jan 28, 2018

Annoyed by password length when add data source for aws_mq_broker. Add validation function to check password length falls into [12, 250].

@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jan 28, 2018
@loivis loivis force-pushed the mq-broker-validate-password-length branch from 7b4cc9c to 7276aea Compare January 28, 2018 01:18
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jan 28, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/mq Issues and PRs that pertain to the mq service. labels Jan 28, 2018
@bflad
Copy link
Contributor

bflad commented Jan 29, 2018

The API documentation also notes some other restrictions, could you add those as well please while you're in here? 😄 https://docs.aws.amazon.com/amazon-mq/latest/api-reference/rest-api-user.html#rest-api-user-attributes

The password of the user. This value must be at least 12 characters long, must contain at least 4 unique characters, and must not contain commas.

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jan 29, 2018
@loivis loivis changed the title resource/aws_mq_broker: validate user password length range resource/aws_mq_broker: validate user password Jan 29, 2018
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jan 29, 2018
@loivis loivis force-pushed the mq-broker-validate-password-length branch from 70f7cc4 to fcb4883 Compare January 29, 2018 10:30
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jan 29, 2018
@loivis loivis force-pushed the mq-broker-validate-password-length branch from fcb4883 to ea50016 Compare January 29, 2018 10:31
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jan 29, 2018
@loivis loivis force-pushed the mq-broker-validate-password-length branch from ea50016 to 88ef005 Compare January 29, 2018 10:32
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jan 29, 2018
@loivis
Copy link
Contributor Author

loivis commented Jan 29, 2018

Thanks for you input, @bflad. I didn't even check aws doc, just added the validation according to the return error. Now I've included those requirements mentioned from the link.

@bflad bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label Jan 29, 2018
@bflad bflad added this to the v1.9.0 milestone Jan 29, 2018
bflad
bflad approved these changes Jan 29, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this contribution, you will save others lots of pain! 🚀

=== RUN   TestAccAwsMqBroker_basic
--- PASS: TestAccAwsMqBroker_basic (993.73s)
...

@bflad bflad merged commit 77583ea into hashicorp:master Jan 29, 2018
bflad added a commit that referenced this pull request Jan 29, 2018
@bflad
Update CHANGELOG for #3164
6b2a6c3
@bflad
Copy link
Contributor

bflad commented Feb 9, 2018

This has been released in terraform-provider-aws version 1.9.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@loivis loivis deleted the mq-broker-validate-password-length branch February 18, 2018 18:47
@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/mq Issues and PRs that pertain to the mq service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@loivis @bflad