Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_emr_cluster: Add step support #3673

Merged
merged 1 commit into from
Mar 15, 2018
Merged

resource/aws_emr_cluster: Add step support #3673

merged 1 commit into from
Mar 15, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 8, 2018 •
edited
Loading

Closes #1593
Closes #1714
Closes #1866

Required for enabling debug logging, among other use cases: https://docs.aws.amazon.com/emr/latest/ManagementGuide/emr-plan-debugging.html

Also includes some minor cleanup surrounding state handling.

Tests:

=== RUN   TestAccAWSEMRCluster_terminationProtected
--- PASS: TestAccAWSEMRCluster_terminationProtected (489.40s)
=== RUN   TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (502.58s)
=== RUN   TestAccAWSEMRCluster_bootstrap_ordering
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (518.69s)
=== RUN   TestAccAWSEMRCluster_Step_Basic
--- PASS: TestAccAWSEMRCluster_Step_Basic (567.02s)
=== RUN   TestAccAWSEMRCluster_security_config
--- PASS: TestAccAWSEMRCluster_security_config (576.14s)
=== RUN   TestAccAWSEMRCluster_basic
--- PASS: TestAccAWSEMRCluster_basic (603.68s)
=== RUN   TestAccAWSEMRCluster_custom_ami_id
--- PASS: TestAccAWSEMRCluster_custom_ami_id (617.01s)
=== RUN   TestAccAWSEMRCluster_Step_Multiple
--- PASS: TestAccAWSEMRCluster_Step_Multiple (616.95s)
=== RUN   TestAccAWSEMRCluster_s3Logging
--- PASS: TestAccAWSEMRCluster_s3Logging (649.73s)
=== RUN   TestAccAWSEMRCluster_instance_group
--- PASS: TestAccAWSEMRCluster_instance_group (667.13s)
=== RUN   TestAccAWSEMRCluster_root_volume_size
--- PASS: TestAccAWSEMRCluster_root_volume_size (896.73s)
=== RUN   TestAccAWSEMRCluster_visibleToAllUsers
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (971.47s)
=== RUN   TestAccAWSEMRCluster_tags
--- PASS: TestAccAWSEMRCluster_tags (1009.42s)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/emr Issues and PRs that pertain to the emr service. labels Mar 8, 2018
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Mar 8, 2018
@bflad bflad force-pushed the f-aws_emr_cluster-steps branch from 22803fa to 6a5a20b Compare March 8, 2018 19:28
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Mar 8, 2018
@bflad bflad requested a review from radeksimko March 8, 2018 20:00
@shanghaiclown
Copy link

Eager to see this merged!

@bflad bflad requested a review from a team March 15, 2018 07:02
tombuildsstuff
tombuildsstuff approved these changes Mar 15, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.12.0 milestone Mar 15, 2018
@bflad bflad merged commit 782672b into master Mar 15, 2018
@bflad bflad deleted the f-aws_emr_cluster-steps branch March 15, 2018 12:48
bflad added a commit that referenced this pull request Mar 15, 2018
@bflad
Update CHANGELOG for #3673
cec323c
This was referenced Mar 15, 2018
Closed
Closed
Closed
@bflad
Copy link
Contributor Author

bflad commented Mar 23, 2018

This has been released in version 1.12.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@oonisim oonisim mentioned this pull request Jul 19, 2019
Closed
@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

@radeksimko radeksimko Awaiting requested review from radeksimko

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/emr Issues and PRs that pertain to the emr service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.12.0
3 participants
@bflad @shanghaiclown @tombuildsstuff