resource/aws_iam_user_login_profile: Fix password_length ValidateFunc

[bflad]

Fixes #3912 which was introduced by #3702 in the v1.12.0 release of the AWS provider.

Before code fix:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSUserLoginProfile_PasswordLength'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSUserLoginProfile_PasswordLength -timeout 120m
=== RUN   TestAccAWSUserLoginProfile_PasswordLength
--- FAIL: TestAccAWSUserLoginProfile_PasswordLength (1.70s)
	testing.go:518: Step 0 error: config is invalid: aws_iam_user_login_profile.user: expected type of password_length to be string
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	1.741s
make: *** [testacc] Error 1

After code fix:

5 tests passed (all tests)
grep -E -e '^=== RUN' -e '^--- (FAIL|PASS):' ~/Downloads/AWS_Provider_-_*.log; rm -f ~/Downloads/AWS_Provider_-_*.log
=== RUN   TestAccAWSUserLoginProfile_keybaseDoesntExist
--- PASS: TestAccAWSUserLoginProfile_keybaseDoesntExist (9.33s)
=== RUN   TestAccAWSUserLoginProfile_notAKey
--- PASS: TestAccAWSUserLoginProfile_notAKey (9.33s)
=== RUN   TestAccAWSUserLoginProfile_PasswordLength
--- PASS: TestAccAWSUserLoginProfile_PasswordLength (13.05s)
=== RUN   TestAccAWSUserLoginProfile_keybase
--- PASS: TestAccAWSUserLoginProfile_keybase (13.50s)
=== RUN   TestAccAWSUserLoginProfile_basic
--- PASS: TestAccAWSUserLoginProfile_basic (21.08s)

[tombuildsstuff]

LGTM 👍

[bflad]

This has been released in version 1.13.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!