Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_waf_ipset: Support resource import #4979

Merged
merged 1 commit into from
Jun 25, 2018
Merged

resource/aws_waf_ipset: Support resource import #4979

merged 1 commit into from
Jun 25, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 25, 2018

Closes #4279

Changes proposed in this pull request:

  • Support resource import via ID

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSWafIPSet'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSWafIPSet -timeout 120m
=== RUN   TestAccAWSWafIPSet_basic
--- PASS: TestAccAWSWafIPSet_basic (12.31s)
=== RUN   TestAccAWSWafIPSet_disappears
--- PASS: TestAccAWSWafIPSet_disappears (9.10s)
=== RUN   TestAccAWSWafIPSet_changeNameForceNew
--- PASS: TestAccAWSWafIPSet_changeNameForceNew (18.14s)
=== RUN   TestAccAWSWafIPSet_changeDescriptors
--- PASS: TestAccAWSWafIPSet_changeDescriptors (17.64s)
=== RUN   TestAccAWSWafIPSet_noDescriptors
--- PASS: TestAccAWSWafIPSet_noDescriptors (8.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	65.613s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/waf Issues and PRs that pertain to the waf service. labels Jun 25, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Jun 25, 2018
@bflad bflad mentioned this pull request Jun 25, 2018
Closed
@bflad bflad requested a review from a team June 25, 2018 18:55
mbfrahry
mbfrahry approved these changes Jun 25, 2018
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad added this to the v1.25.0 milestone Jun 25, 2018
@bflad bflad merged commit 24e937a into master Jun 25, 2018
@bflad bflad deleted the f-aws_waf_ipset-import branch June 25, 2018 19:41
bflad added a commit that referenced this pull request Jun 25, 2018
@bflad
Update CHANGELOG for #4979
8be34c1
@bflad
Copy link
Contributor Author

bflad commented Jun 27, 2018

This has been released in version 1.25.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/waf Issues and PRs that pertain to the waf service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.25.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Import functionality for aws_waf_ipset
2 participants
@bflad @mbfrahry