resource/aws_ami*: Fix ena_support attribute for copy/from_instance and uncouple common schema function

[bflad]

Regression introduced by #5395
Fixes #5431

Changes proposed in this pull request:

• Split out resourceAwsAmiCommonSchema to aws_ami ("uncomputed" version), aws_ami_copy ("computed" version), and aws_ami_from_instance ("computed" version)
• Ensure ena_support attribute is Computed: true for aws_ami_copy and aws_ami_from_instance

Output from acceptance testing:

5 tests passed (all tests)
=== RUN   TestAccAWSAMI_basic
--- PASS: TestAccAWSAMI_basic (56.17s)
=== RUN   TestAccAWSAMI_snapshotSize
--- PASS: TestAccAWSAMI_snapshotSize (56.51s)
=== RUN   TestAccAWSAMIFromInstance
--- PASS: TestAccAWSAMIFromInstance (143.70s)
=== RUN   TestAccAWSAMILaunchPermission_Basic
--- PASS: TestAccAWSAMILaunchPermission_Basic (333.48s)
=== RUN   TestAccAWSAMICopy
--- PASS: TestAccAWSAMICopy (464.29s)

[paultyng]

Is there no new acc test to demonstrate the issue?

[bflad]

@paultyng sorry, adding the test took longer than expected due to these older resources missing broken out acceptance test check functions.

On master:

=== RUN   TestAccAWSAMICopy_EnaSupport
--- FAIL: TestAccAWSAMICopy_EnaSupport (377.09s)
	testing.go:518: Step 0 error: After applying this step, the plan was not empty:

		DIFF:

		DESTROY/CREATE: aws_ami_copy.test
		  architecture:             "x86_64" => "<computed>"
		  ebs_block_device.#:       "1" => "<computed>"
		  ena_support:              "true" => "false" (forces new resource)
		  encrypted:                "false" => "false"
		  ephemeral_block_device.#: "0" => "<computed>"
		  image_location:           "187416307283/tf-acc-test-4368034538206458338-copy" => "<computed>"
		  kernel_id:                "" => "<computed>"
		  kms_key_id:               "" => "<computed>"
		  manage_ebs_snapshots:     "true" => "<computed>"
		  name:                     "tf-acc-test-4368034538206458338-copy" => "tf-acc-test-4368034538206458338-copy"
		  ramdisk_id:               "" => "<computed>"
		  root_device_name:         "/dev/sda1" => "<computed>"
		  root_snapshot_id:         "snap-05f26621118b88b48" => "<computed>"
		  source_ami_id:            "ami-08143070" => "ami-08143070"
		  source_ami_region:        "us-west-2" => "us-west-2"
		  sriov_net_support:        "simple" => "<computed>"
		  virtualization_type:      "hvm" => "<computed>"

On this branch:

=== RUN   TestAccAWSAMICopy_basic
--- PASS: TestAccAWSAMICopy_basic (461.78s)
=== RUN   TestAccAWSAMICopy_EnaSupport
--- PASS: TestAccAWSAMICopy_EnaSupport (404.16s)
=== RUN   TestAccAWSEBSSnapshot_basic
--- PASS: TestAccAWSEBSSnapshot_basic (152.68s)
=== RUN   TestAccAWSEBSSnapshot_withDescription
--- PASS: TestAccAWSEBSSnapshot_withDescription (43.34s)
=== RUN   TestAccAWSEBSSnapshot_withKms
--- PASS: TestAccAWSEBSSnapshot_withKms (77.37s)

[catsby]

👍

[bflad]

This has been released in version 1.31.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!