Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_cloudwatch_metric_alarm: Validate alarm actions #6151

Merged
merged 1 commit into from
Oct 14, 2018

Conversation

tkbky
Copy link
Contributor

@tkbky tkbky commented Oct 14, 2018

Fixes #6092

Changes proposed in this pull request:

  • Validate that alarm_actions is a valid ARN.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchMetricAlarm'

TF_ACC=1 go test ./... -v -run=TestAccAWSCloudWatchMetricAlarm -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCloudWatchMetricAlarm_importBasic
--- PASS: TestAccAWSCloudWatchMetricAlarm_importBasic (31.49s)
=== RUN   TestAccAWSCloudWatchMetricAlarm_basic
--- PASS: TestAccAWSCloudWatchMetricAlarm_basic (28.72s)
=== RUN   TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm
--- PASS: TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm (26.34s)
=== RUN   TestAccAWSCloudWatchMetricAlarm_treatMissingData
--- PASS: TestAccAWSCloudWatchMetricAlarm_treatMissingData (45.47s)
=== RUN   TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
--- PASS: TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (46.52s)
=== RUN   TestAccAWSCloudWatchMetricAlarm_extendedStatistic
--- PASS: TestAccAWSCloudWatchMetricAlarm_extendedStatistic (25.65s)
=== RUN   TestAccAWSCloudWatchMetricAlarm_missingStatistic
--- PASS: TestAccAWSCloudWatchMetricAlarm_missingStatistic (8.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	212.588s
...

@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Oct 14, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. labels Oct 14, 2018
@bflad bflad added this to the v1.41.0 milestone Oct 14, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tkbky! 🚀

--- PASS: TestAccAWSCloudWatchMetricAlarm_missingStatistic (1.96s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm (4.13s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_extendedStatistic (4.16s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_basic (4.26s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_importBasic (4.61s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_treatMissingData (6.98s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (7.35s)

@bflad bflad merged commit affec9c into hashicorp:master Oct 14, 2018
bflad added a commit that referenced this pull request Oct 14, 2018
@bflad
Copy link
Contributor

bflad commented Oct 18, 2018

This has been released in version 1.41.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@prasanthsurapaneni
Copy link

. we are using cloudwatch alarm for setting ec2 recovery and the validation for the alarm action is failing across the board. This has impaired our production instances with entire workspaces getting errored out. Please look into this.

@bflad
Copy link
Contributor

bflad commented Oct 19, 2018

@prasanthsurapaneni please see #6203

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_cloudwatch_metric_alarm does not validate input on alarm_actions
3 participants