App Service / Function Apps: support for updating #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` $ acctests azurerm TestAccAzureRMAppService_tagsUpdate === RUN TestAccAzureRMAppService_tagsUpdate --- FAIL: TestAccAzureRMAppService_tagsUpdate (109.41s) testing.go:513: Step 1 error: Check failed: Check 2/4 error: azurerm_app_service.test: Attribute 'tags.%' expected "2", got "1" FAIL exit status 1 FAIL github.com/terraform-providers/terraform-provider-azurerm/azurerm 109.444s ```
``` $ acctests azurerm TestAccAzureRMAppService_tagsUpdate === RUN TestAccAzureRMAppService_tagsUpdate --- PASS: TestAccAzureRMAppService_tagsUpdate (144.13s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 144.156s ```
tombuildsstuff
added
enhancement
service/app-service
service/functions
tombuildsstuff
force-pushed
the
app-service-updates
branch
from
62b4ef9
to
8ba7886
Compare
|
App Service tests pass:
|
tombuildsstuff
changed the title
|
WIP as I'm fixing an issue with the Function App tests |
|
Fixes #359 |
``` $ acctests azurerm TestAccAzureRMFunctionApp_siteConfigMulti === RUN TestAccAzureRMFunctionApp_siteConfigMulti --- PASS: TestAccAzureRMFunctionApp_siteConfigMulti (225.65s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 225.693s ```
tombuildsstuff
changed the title
|
Function App tests pass:
|
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of SDKv15 it appears that Update support is now working; as such I've removed the
ForceNewfrom the App Service / Function App resources.We can verify this works as the update tests fail prior to the Update method being implemented:
which subsequently pass: