-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add availability set data source #2850
add availability set data source #2850
Conversation
corrections function rename and provider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @MattMencel
Thanks for this PR :)
Taking a look through this looks pretty good to me - if we can add address the comments this should otherwise looks good to me 👍
Thanks!
I'm still putting the pieces together.... so I couldn't figure out originally why the Now I see how that ties back to the Azure SDK from the resource and how that relates to the Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @MattMencel
Thanks for pushing those changes - besides a couple of minor comments (which I'm going to push a commit to fix - I hope you don't mind) this otherwise LGTM 👍
Thanks!
$ acctests azurerm TestAccDataSourceAvailabilitySet_basic === RUN TestAccDataSourceAvailabilitySet_basic === PAUSE TestAccDataSourceAvailabilitySet_basic === CONT TestAccDataSourceAvailabilitySet_basic --- PASS: TestAccDataSourceAvailabilitySet_basic (109.16s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 111.046s
This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.23.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Fixes #2800
First attempt to try to help tackle some of the stuff labeled "good first issue".