More fixes for issue #3925 #3977

stweil · 2022-12-11T16:23:58Z

No description provided.

stweil · 2022-12-11T22:04:20Z

@SpaceView, @zdenop, could you please try whether you still have an issue after applying this pull request? Here is my test result:

+ tesseract num.ocra.exp0.png num.ocra.exp0 nobatch box.train
APPLY_BOXES:
   Boxes read from boxfile:      10
   Found 10 good blobs.
Generated training data for 1 words
+ unicharset_extractor num.ocra.exp0.box
Extracting unicharset from box file num.ocra.exp0.box
Wrote unicharset file unicharset
+ set_unicharset_properties -U unicharset -O num.unicharset --script_dir=/home/stweil/src/github/tesseract-ocr/langdata/
Loaded unicharset of size 13 from file unicharset
Setting unichar properties
Setting script properties
Writing unicharset to file num.unicharset
+ shapeclustering -F font_properties -U num.unicharset num.ocra.exp0.tr
Reading num.ocra.exp0.tr ...
Building master shape table
Computing shape distances...
Stopped with 0 merged, min dist 999.000000
Computing shape distances...
Stopped with 0 merged, min dist 999.000000
Computing shape distances...
Stopped with 0 merged, min dist 999.000000
Computing shape distances... 0
Stopped with 0 merged, min dist 999.000000
Computing shape distances... 0
Stopped with 0 merged, min dist 999.000000
Computing shape distances... 0
Stopped with 0 merged, min dist 999.000000
Computing shape distances... 0
Stopped with 0 merged, min dist 999.000000
Computing shape distances... 0
Stopped with 0 merged, min dist 999.000000
Computing shape distances... 0
Stopped with 0 merged, min dist 999.000000
Computing shape distances... 0
Stopped with 0 merged, min dist 999.000000
Computing shape distances... 0
Stopped with 0 merged, min dist 999.000000
Computing shape distances... 0
Stopped with 0 merged, min dist 999.000000
Computing shape distances... 0
Stopped with 0 merged, min dist 999.000000
Computing shape distances...
Stopped with 0 merged, min dist 999.000000
Computing shape distances...
Stopped with 0 merged, min dist 999.000000
Computing shape distances... 0 1 2 3 4 5 6 7 8 9
Stopped with 0 merged, min dist 0.256098
Master shape_table:Number of shapes = 10 max unichars = 1 number with multiple unichars = 0
+ mftraining -F font_properties -U num.unicharset -O num.unicharset num.ocra.exp0.tr
Read shape table shapetable of 10 shapes
Reading num.ocra.exp0.tr ...
Warning: no protos/configs for Joined in CreateIntTemplates()
Warning: no protos/configs for |Broken|0|1 in CreateIntTemplates()
Done!
+ cntraining num.ocra.exp0.tr
Reading num.ocra.exp0.tr ...
Clustering ...

Writing normproto ...
+ mv inttemp num.inttemp
+ mv pffmtable num.pffmtable
+ mv normproto num.normproto
+ mv shapetable num.shapetable
+ combine_tessdata num.
Version:5.2.0-108-gf77c
1:unicharset:size=837, offset=192
3:inttemp:size=134553, offset=1029
4:pffmtable:size=110, offset=135582
5:normproto:size=1382, offset=135692
13:shapetable:size=184, offset=137074
23:version:size=15, offset=137258
Combining tessdata files
Output num.traineddata created successfully.
+ mkdir tessdata
+ mv num.traineddata tessdata
+ tesseract num.ocra.exp0.png - --psm 7 -l num --tessdata-dir tessdata
0123456789

src/classify/intproto.cpp

This allows removing a reinterpret_cast and fixes a runtime error with sanitizers: runtime error: call to function tesseract::MakePotentialClusters(tesseract::ClusteringContext*, tesseract::CLUSTER*, int) through pointer to incorrect function type 'void (*)(...)' Signed-off-by: Stefan Weil <sw@weilnetz.de>

…ract-ocr#3925) It is required for mftraining which otherwise writes a wrong shapetable. Signed-off-by: Stefan Weil <sw@weilnetz.de>

The old code did not work correctly if FClass->font_set.size() was 0. It created the FontSet fs with size 1 instead of 0. Signed-off-by: Stefan Weil <sw@weilnetz.de>

It was triggered by mftraining. Signed-off-by: Stefan Weil <sw@weilnetz.de>

mftraining crashed if the search did not find anything. Signed-off-by: Stefan Weil <sw@weilnetz.de>

mftraining crashed because the returned value was 1 instead of 0 for the first call of UnicityTable::push_back. Signed-off-by: Stefan Weil <sw@weilnetz.de>

It crashed when running mftraining with fs.size() == 0. Signed-off-by: Stefan Weil <sw@weilnetz.de>

It crashed when running mftraining because unicharset_size in file "inttemp" was written with 8 bytes instead of 4 bytes. Signed-off-by: Stefan Weil <sw@weilnetz.de>

This fixes duplicate delete when running cntraining. Signed-off-by: Stefan Weil <sw@weilnetz.de>

…plates UnicityTable did not provide the [] operator, so add it for this change. Suggested-by: Egor Pugin <egor.pugin@gmail.com> Signed-off-by: Stefan Weil <sw@weilnetz.de>

This comment was marked as resolved.

Sign in to view

stweil force-pushed the fix3925 branch from 91920c4 to 8a62630 Compare December 11, 2022 22:00

stweil force-pushed the fix3925 branch from 8a62630 to 5a8a4d6 Compare December 11, 2022 22:07

egorpugin reviewed Dec 12, 2022

View reviewed changes

src/classify/intproto.cpp Outdated Show resolved Hide resolved

stweil added 9 commits December 12, 2022 08:12

Add missing serialization to FILE for vector of pointers (issue tesse…

41920d7

…ract-ocr#3925) It is required for mftraining which otherwise writes a wrong shapetable. Signed-off-by: Stefan Weil <sw@weilnetz.de>

Fix function Classify::CreateIntTemplates (issue tesseract-ocr#3925)

12ef9b9

The old code did not work correctly if FClass->font_set.size() was 0. It created the FontSet fs with size 1 instead of 0. Signed-off-by: Stefan Weil <sw@weilnetz.de>

Remove assertion in function NewSimpleProto (issue tesseract-ocr#3925)

8aaf5fe

It was triggered by mftraining. Signed-off-by: Stefan Weil <sw@weilnetz.de>

Fix function ComputeChiSquared (issue tesseract-ocr#3925)

d5e9dd2

mftraining crashed if the search did not find anything. Signed-off-by: Stefan Weil <sw@weilnetz.de>

Fix function UnicityTable::push_back (issue tesseract-ocr#3925)

0c036a5

mftraining crashed because the returned value was 1 instead of 0 for the first call of UnicityTable::push_back. Signed-off-by: Stefan Weil <sw@weilnetz.de>

Fix function tesseract::write_set (issue tesseract-ocr#3925)

2070d28

It crashed when running mftraining with fs.size() == 0. Signed-off-by: Stefan Weil <sw@weilnetz.de>

Fix function Classify::WriteIntTemplates (issue tesseract-ocr#3925)

f81df78

It crashed when running mftraining because unicharset_size in file "inttemp" was written with 8 bytes instead of 4 bytes. Signed-off-by: Stefan Weil <sw@weilnetz.de>

Fix function ReadTrainingSamples (issue tesseract-ocr#3925)

c7477f5

This fixes duplicate delete when running cntraining. Signed-off-by: Stefan Weil <sw@weilnetz.de>

stweil force-pushed the fix3925 branch from 5a8a4d6 to 8b150da Compare December 12, 2022 07:20

Replace at accessor by [] operator in function Classify::CreateIntTem…

f4ca51c

…plates UnicityTable did not provide the [] operator, so add it for this change. Suggested-by: Egor Pugin <egor.pugin@gmail.com> Signed-off-by: Stefan Weil <sw@weilnetz.de>

stweil force-pushed the fix3925 branch from 8b150da to f4ca51c Compare December 12, 2022 07:37

stweil requested a review from zdenop December 12, 2022 09:18

stweil mentioned this pull request Dec 12, 2022

Many bugs in training the legacy engine #3925

Closed

zdenop approved these changes Dec 13, 2022

View reviewed changes

amitdo added the regression label Dec 13, 2022

stweil merged commit 369b811 into tesseract-ocr:main Dec 13, 2022

stweil deleted the fix3925 branch December 13, 2022 07:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More fixes for issue #3925 #3977

More fixes for issue #3925 #3977

stweil commented Dec 11, 2022

This comment was marked as resolved.

stweil commented Dec 11, 2022

More fixes for issue #3925 #3977

More fixes for issue #3925 #3977

Conversation

stweil commented Dec 11, 2022

This comment was marked as resolved.

stweil commented Dec 11, 2022