Fix FP division by zero (issue #3995) #3996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvezdochiot
reviewed
Jan 19, 2023
src/wordrec/language_model.cpp
Outdated
| @@ -1375,7 +1375,12 @@ void LanguageModel::ExtractFeaturesFromPath(const ViterbiStateEntry &vse, float | |||
| // features[PTRAIN_NUM_BAD_FONT] = vse.consistency_info.inconsistent_font; | |||
|
|
|||
| // Classifier-related features. | |||
| features[PTRAIN_RATING_PER_CHAR] = vse.ratings_sum / static_cast<float>(vse.outline_length); | |||
| if (vse.outline_length != 0.0f) { | |||
There was a problem hiding this comment.
features[PTRAIN_RATING_PER_CHAR] = (vse.outline_length > 0.0f) ? (vse.ratings_sum / static_cast<float>(vse.outline_length)) : 0.0f;There was a problem hiding this comment.
Why would that be better?
There was a problem hiding this comment.
Hi @stweil .
(vse.outline_length != 0.0f)!!! (float?)
If not (float) then replace with (vse.outline_length != 0).
There was a problem hiding this comment.
Thanks. I replaced != by > now. Please review the updated code.
There was a problem hiding this comment.
Hi @stweil .
vse.outline_length is it (float)? See #3996 (comment)
PS:
tesseract/src/wordrec/lm_state.h
Line 190 in 4142b32
Resolved. 👍
Signed-off-by: Stefan Weil <sw@weilnetz.de>
…sue tesseract-ocr#3995) Signed-off-by: Stefan Weil <sw@weilnetz.de>
zvezdochiot
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.