Fix loading of sublangs (regression) #4141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 5, 2023
stweil
commented
Oct 5, 2023
| @@ -308,7 +308,8 @@ int Tesseract::init_tesseract(const std::string &arg0, const std::string &textba | |||
| // Load the rest into sub_langs_. | |||
| // A range based for loop does not work here because langs_to_load | |||
| // might be changed in the loop when a new submodel is found. | |||
| for (auto &lang_to_load : langs_to_load) { | |||
There was a problem hiding this comment.
I should have read my own comment which said that using a range based loop is a bad idea here.
There was a problem hiding this comment.
LOL, but seriously, maybe you should add WARNING: in the start of the comment line.
Model files which where defined with tessedit_load_sublangs in another model file where no longer loaded since Tesseract release 5.0.0-rc2. Fixes: 9091055 ("Fix loading of additional model files") Signed-off-by: Stefan Weil <sw@weilnetz.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model files which where defined with tessedit_load_sublangs in another model file where no longer loaded since Tesseract release 5.0.0-rc2.
Fixes: 9091055 ("Fix loading of additional model files")