Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <Unicode> output and issues reported by Coverity Scan for PAGE XML renderer #4234

Merged
merged 2 commits into from
May 3, 2024

Conversation

stweil
Copy link
Contributor

@stweil stweil commented May 3, 2024

No description provided.

stweil added 2 commits May 3, 2024 07:46
Fixes: 577e8a8 ("Add PAGE XML renderer / export (tesseract-ocr#4214)")
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Use also enum names instead of numeric values where possible.

Fixes: 577e8a8 ("Add PAGE XML renderer / export (tesseract-ocr#4214)")
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Copy link
Contributor

@JKamlah JKamlah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @stweil

@stweil stweil merged commit dff5ebd into tesseract-ocr:main May 3, 2024
5 of 7 checks passed
@stweil stweil deleted the page branch May 3, 2024 06:48
@amitdo
Copy link
Collaborator

amitdo commented May 3, 2024

Next time, I suggest to mention the service name "Coverity Scan" also in the commit message/body.

@stweil
Copy link
Contributor Author

stweil commented May 3, 2024

Up to now I used "CID" in the commit summary, so you can search for that string to find related commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants