cmake: Correctly set the soversion based on SemVer properties #4319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this project follows Semantic Versioning, the shared object version should match these semantics. The two options that make sense here are to have the soversion set to the version major (so only breaking changes are tracked) or to set to version major and minor (so breaking and API additions are tracked). Since the Windows version of the library already uses version major and version minor, let's just do this universally. Fixes: 832926f ("Update library version handling for cmake") Signed-off-by: Neal Gompa <neal@gompa.dev>
egorpugin
approved these changes
Sep 18, 2024
|
thanks. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this project follows Semantic Versioning, the shared object version should match these semantics.
The two options that make sense here are to have the soversion set to the version major (so only breaking changes are tracked) or to set to version major and minor (so breaking and API additions are tracked).
Since the Windows version of the library already uses version major and version minor, let's just do this universally.
Fixes: 832926f ("Update library version handling for cmake")