feat: use docker credential helpers to get auth #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solves the problems I was having in test-kitchen#189 and lets me use Amazon ECR for images. Signed-off-by: Ben Dean <ben.dean@ontariosystems.com>
|
this would also solve #290 |
damacus
approved these changes
Feb 20, 2023
This was referenced Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
docker_config_creds: truethis will use any docker credential helpers defined in~/.docker/config.jsonIn particular this makes it possible to use the AWS ECR Docker Credential Helper to pull images from private ECR registries
Issues Resolved
This is related to the work I did ages ago on PR #189 and builds on #262
Type of Change
I would say this is a new feature.
Check List
New functionality includes testsAll tests passnote that there aren't any tests for the other features around docker credentials.