Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bento's Atlas boxes by default if detected #195

Merged
merged 1 commit into from
Jan 15, 2016
Merged

Use Bento's Atlas boxes by default if detected #195

merged 1 commit into from
Jan 15, 2016

Conversation

andytson
Copy link
Contributor

@andytson andytson commented Sep 6, 2015

Bento hosts its base boxes on https://atlas.hashicorp.com/bento

I'm unsure whether it's worth removing default_box_url, but from a class-api BC, keeping this in will still allow for monkey-patching new behaviours in.

Fixes #193

@legal90
Copy link
Contributor

legal90 commented Sep 12, 2015

It is a good suggestion and it allows to do not care about box urls at all. It also supersedes my previous PR #196
But please note, that actual box name format <atlas_username>/<box_name> is available only for Vagrant 1.5+ (http://www.vagrantup.com/blog/vagrant-1-5-and-vagrant-cloud.html)

Currently README tells that the minimal supported version of Vagrant is 1.1, so it should be changed to 1.5 after this pull request.

@legal90
Copy link
Contributor

legal90 commented Oct 6, 2015

@tyler-ball @fnichol Please, take a look at this PR.

@davidski
Copy link

davidski commented Oct 7, 2015

Would love to see this merged and released. Current test-kitchen behavior causes opscode-* boxes to be downloaded and preferred over the atlas-hosted bento boxes, duplicating storage and loosing out on version updates.

@cheeseplus cheeseplus added this to the 0.18.0 milestone Jan 15, 2016
@cheeseplus
Copy link
Contributor

all the 👍

cheeseplus pushed a commit that referenced this pull request Jan 15, 2016
Use Bento's Atlas boxes by default if detected
@cheeseplus cheeseplus merged commit 9eb3e6c into test-kitchen:master Jan 15, 2016
@tas50
Copy link
Member

tas50 commented Jan 15, 2016

Looking forward to this one. Thanks everyone

@andytson andytson deleted the feature/bento-atlas branch January 18, 2016 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants