Generic text field #61
Conversation
nicopaul
force-pushed
the
GenericTextField
branch
3 times, most recently
from
402ffb9
to
a90532a
Compare
…actTextFieldAssert and TextFieldAssert
nicopaul
force-pushed
the
GenericTextField
branch
from
a90532a
to
5409425
Compare
|
Looks good to me :) |
| @@ -54,6 +55,10 @@ protected String getHTMLFilePath() { | |||
|
|
|||
| // UTILITY | |||
|
|
|||
| protected void assertPageObjectCanBeInitialized(PageObject object) { | |||
There was a problem hiding this comment.
I cannot find any usage of this assertion within the PR. Why did you add it?
There was a problem hiding this comment.
I need this assertion for other PageObjects which are based on GenericTextField.
That is why I added it on this branch, so I dont have to add it on all the other Branches.
There was a problem hiding this comment.
I looked at some of the branches in your repo (EmailField, UrlField, SearchField) and didn't find any references to the method. Can you point me to a branch, where you are actually using it? I don't want to integrate dead code.
There was a problem hiding this comment.
The function assertPageObjectCanBeInitalized is on my master branch and not on my GenerixTextField Branch, maybe thats why it is irritating.
I need this function in The Following Classes/Branches:
GenericList --> GenericListIntegrationTest
OrderedList --> OrderedListIntegrationTest
UnorderedList --> UnorderedListIntegrationTest
Form --> FormIntegrationTest
Paragraph --> ParagraphIntegrationTest
I thought about adding this test for the validation of mapping/class to the GenericTextField-Classes. If I should add it, I can do this on Monday.
There was a problem hiding this comment.
Thanks!
I'll keep this commit out, but accept the rest of your pull request. You can add the commit to a future PR where the test method is used.
| * | ||
| * @since 1.2 | ||
| */ | ||
| public class GenericTextFieldMatcher extends PageObjectMatcher { |
There was a problem hiding this comment.
And one more thing: please turn the constructor private (instead of protected), so that codacy is happy?
nicopaul
force-pushed
the
GenericTextField
branch
from
2f5fd96
to
63aa014
Compare
nicopaul
force-pushed
the
GenericTextField
branch
from
63aa014
to
11736aa
Compare
|
Nico, I merged your backport of |
Added all functionalities of the PageObject GenericTextField:
-PageObject GenericTextField
-GenericTextFieldTest
-IntegrationTest
-Assert
-AssertTest
-Matcher
-MatcherTest
This change is