This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Generic select #68
Merged
Generic select #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slu-it
reviewed
Jan 4, 2017
| @Test | ||
| public final void testThatListWithOptionTextsIsReturnedCorrectly_singleSelect() { | ||
| List<String> texts = page.singleSelect.getAllOptionTexts(); | ||
| assertThat(texts.get(0).equals("one"), is(true)); |
There was a problem hiding this comment.
assertThat(texts.get(0).equals("one"), is(true)); >> assertThat(texts.get(0), is("one"));
(for all tests in this class)
slu-it
reviewed
Jan 4, 2017
| @Test | ||
| public final void testThatListWithOptionTextsIsReturnedCorrectly_emptySelect() { | ||
| List<String> optionTexts = page.emptySelect.getAllOptionTexts(); | ||
| assertThat(optionTexts.isEmpty(), is(true)); |
There was a problem hiding this comment.
assertThat(optionTexts.isEmpty(), is(true)); >> assertThat(optionTexts, is(empty()));
There was a problem hiding this comment.
Which import do i have to use?
java.util? But isn't Optional.empty() java8?
There was a problem hiding this comment.
org.hamcrest.Matchers.empty
All Hamcrest matchers have a factory method within the Matchers class.
There was a problem hiding this comment.
oh just overlooked it
thanks
slu-it
reviewed
Jan 4, 2017
| @Test | ||
| public final void testThatListWithOptionValuesIsReturnedCorrectly_emptySelect() { | ||
| List<String> optionValues = page.emptySelect.getAllOptionValues(); | ||
| assertThat(optionValues.isEmpty(), is(true)); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is