Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enhanced linting #158

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

stevenh
Copy link
Contributor

@stevenh stevenh commented Sep 7, 2024

Add a configuration file which makes it much more strict.

Fix shadowed error variables flagged by linter.

Remove CI timeout as its now present in the config.

@stevenh stevenh requested a review from a team as a code owner September 7, 2024 09:26
@stevenh
Copy link
Contributor Author

stevenh commented Sep 7, 2024

This should only be merged after #141 which refactors and fixes all the linting issues.

@stevenh stevenh force-pushed the ci/enhanced-linting branch from 4412164 to df785fe Compare October 7, 2024 11:41
Add a configuration file which makes it much more strict.

Fix shadowed error variables flagged by linter.

Remove CI timeout as its now present in the config.
@stevenh stevenh force-pushed the ci/enhanced-linting branch from df785fe to adbf57f Compare October 7, 2024 11:44
@mdelapenya mdelapenya self-assigned this Oct 7, 2024
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Oct 7, 2024
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya merged commit 5d57bf3 into testcontainers:main Oct 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants