Improve error reporting when loading the Docker configuration file #1263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request improves error handling while reading the Docker context configuration file. It throws a new
DockerConfigurationException
instead of silently failing.Also, since
GetCurrentEndpoint()
can't returnnull
anymore there's no need to try the defaultGetSocketPathFromHomeDesktopDir()
andGetSocketPathFromHomeRunDir()
socket paths.Why is it important?
Silently returning
null
instead of throwing proper exceptions makes it harder to diagnose issues.Related issues
How to test this PR
The
DockerConfigTests
were updated and a newThrowsWhenDockerConfigEndpointNotFound
test was added.