-
-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added NATS JetStream example #1190
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I guess you did not use the code generation tool for bootstrapping the example module, right? I'm missing the mkdocs.yml file being updated, or the docs/examples files. Could you run the generator first, and then apply your changes? 🙏 That will bring consistency across the docs site too. |
Ah no I did not, I will give this ago using the generator |
Tested locally and passes, I still included the |
Unsure if I have missed something when running the mod gen but the Github tests are returning this error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments before the final review, but great job with the contribution!
Let's keep it, as it's useful for testing, and probably added once converted into a real module (I encourage you to convert this example into a module sooner than later 🙏 ) |
Ahhh I changed it before seeing this message as I was having a small bug issue locally, but may just have been WSL2 playing up |
@adoublef could you share the command you used to generate the scaffolding? I'd say it was: go run . --name nats --image "nats:latest" --title Nats But wanted to double check, as it would have generated the right wording regarding capital chats and modified files. Please make sure to also fix #1190 (comment) |
No I did |
Kudos, SonarCloud Quality Gate passed! |
* main: chore(deps): bump go.mongodb.org/mongo-driver in /examples/mongodb (#1233) chore(deps): bump google.golang.org/api from 0.123.0 to 0.124.0 in /examples (#1244) chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (#1241) chore(deps): bump github.com/aws/aws-sdk-go in /modules/localstack (#1242) added NATS JetStream example (#1190) chore(deps): bump github.com/imdario/mergo from 0.3.12 to 0.3.15 (#1204) chore(deps): bump cloud.google.com/go/firestore in /examples/firestore (#1216)
…containerd-1.7.1 * main: chore(deps): bump golang.org/x/sys from 0.7.0 to 0.8.0 (#1202) chore(deps): bump github.com/stretchr/testify from 1.8.2 to 1.8.3 (#1232) chore(deps): bump cloud.google.com/go/spanner in /examples/spanner (#1226) chore: Removes the refercence about docker 22.06 from the docker-compose docs and updates the replace directive for the compose module. (#1243) chore(deps): bump go.mongodb.org/mongo-driver in /examples/mongodb (#1233) chore(deps): bump google.golang.org/api from 0.123.0 to 0.124.0 in /examples (#1244) chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (#1241) chore(deps): bump github.com/aws/aws-sdk-go in /modules/localstack (#1242) added NATS JetStream example (#1190) chore(deps): bump github.com/imdario/mergo from 0.3.12 to 0.3.15 (#1204) chore(deps): bump cloud.google.com/go/firestore in /examples/firestore (#1216) chore(deps): bump k8s.io/client-go from 0.22.5 to 0.27.2 in /modules/k3s (#1211) chore(deps): bump go.mongodb.org/mongo-driver in /examples/mongodb (#1092) chore(deps): bump github.com/neo4j/neo4j-go-driver/v5 in /modules/neo4j (#1206) chore(deps): bump github.com/twmb/franz-go in /modules/redpanda (#1201) chore(deps): bump google.golang.org/api from 0.121.0 to 0.123.0 in /examples (#1229) chore(deps): bump github.com/stretchr/testify from 1.8.2 to 1.8.3 (#1228) chore: use fixed version in k3s module (#1225)
* main: (22 commits) docs: document the Go version (testcontainers#1246) chore(deps): bump github.com/aws/aws-sdk-go-v2/config (testcontainers#1222) chore(deps): bump golang.org/x/sys from 0.7.0 to 0.8.0 (testcontainers#1202) chore(deps): bump github.com/stretchr/testify from 1.8.2 to 1.8.3 (testcontainers#1232) chore(deps): bump cloud.google.com/go/spanner in /examples/spanner (testcontainers#1226) chore: Removes the refercence about docker 22.06 from the docker-compose docs and updates the replace directive for the compose module. (testcontainers#1243) chore(deps): bump go.mongodb.org/mongo-driver in /examples/mongodb (testcontainers#1233) chore(deps): bump google.golang.org/api from 0.123.0 to 0.124.0 in /examples (testcontainers#1244) chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (testcontainers#1241) chore(deps): bump github.com/aws/aws-sdk-go in /modules/localstack (testcontainers#1242) added NATS JetStream example (testcontainers#1190) chore(deps): bump github.com/imdario/mergo from 0.3.12 to 0.3.15 (testcontainers#1204) chore(deps): bump cloud.google.com/go/firestore in /examples/firestore (testcontainers#1216) chore(deps): bump k8s.io/client-go from 0.22.5 to 0.27.2 in /modules/k3s (testcontainers#1211) chore(deps): bump go.mongodb.org/mongo-driver in /examples/mongodb (testcontainers#1092) chore(deps): bump github.com/neo4j/neo4j-go-driver/v5 in /modules/neo4j (testcontainers#1206) chore(deps): bump github.com/twmb/franz-go in /modules/redpanda (testcontainers#1201) chore(deps): bump google.golang.org/api from 0.121.0 to 0.123.0 in /examples (testcontainers#1229) chore(deps): bump github.com/stretchr/testify from 1.8.2 to 1.8.3 (testcontainers#1228) ...
What does this PR do?
This PR adds a NATS example as per #636 using the same pattern other examples are written.
Why is it important?
NATS is technology that I see quite often in blogs/tutorials when dealing with event-driven architecture and Go (we also see that we have alternatives with Kafka, PubSub included here already too).
Related issues