Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert NATS example into a module #1559

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

mdelapenya
Copy link
Member

What does this PR do?

This PR migrates the existing NATS example into a module, adding the ability to set up user, password and/or command line arguments that will be passed to the nats-server process in the container.

Code has been copied from the NATS implementation from testcontainers-node: https://github.com/testcontainers/testcontainers-node/blob/main/packages/modules/nats/src/nats-container.ts

Why is it important?

More modules, as we already had the foundation as an example.

@mdelapenya mdelapenya requested a review from a team as a code owner August 31, 2023 15:28
@mdelapenya mdelapenya added the feature New functionality or new behaviors on the existing one label Aug 31, 2023
@mdelapenya mdelapenya self-assigned this Aug 31, 2023
@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit de34dd8
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64f0b19d9a224e0009dbba4a
😎 Deploy Preview https://deploy-preview-1559--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mdelapenya mdelapenya merged commit 0d3de91 into testcontainers:main Aug 31, 2023
93 checks passed
@mdelapenya
Copy link
Member Author

@adoublef please take a look, we converted the example into a module, with some more features, like setting user/pass.

mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Sep 1, 2023
* main:
  chore: define interfaces for file and project generation (testcontainers#1568)
  chore(deps): bump mkdocs-material from 8.2.7 to 9.2.6 (testcontainers#1567)
  chore(deps): bump the all group in /modules/neo4j with 1 update (testcontainers#1562)
  chore(deps): bump the all group in /modules/clickhouse with 1 update (testcontainers#1563)
  chore(deps): bump the all group in /modules/localstack with 1 update (testcontainers#1564)
  Update actions/github-script to 6.4.1 (testcontainers#1561)
  chore: Update Pipenv to use Python 3.8 (testcontainers#1558)
  feat: convert NATS example into a module (testcontainers#1559)
  chore(deps): bump the all group in /modulegen with 1 update (testcontainers#1554)
  modulegen: use cobra instead of native golang flag (testcontainers#1550)
@adoublef
Copy link
Contributor

adoublef commented Sep 1, 2023

Oh excellent, thank you. I will be taking a look. Similar to how the Postgres options includes WithConfigFile I could look into something similar for NATS.

@mdelapenya mdelapenya deleted the nats-module branch September 6, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or new behaviors on the existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants