chore: lookup exposed ports in the image from Config, not from ContainerConfig #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
changed the title
|
Core tests passed, merging now to rebase existing PRs |
mdelapenya
changed the title
vvoland
approved these changes
Dec 21, 2023
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Dec 21, 2023
* main: chore: lookup exposed ports in the image from Config, not from ContainerConfig (testcontainers#2039)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR uses the Docker type
image.Configto the lookup of the exposed ports from the underlying image.Why is it important?
If there are no exposed ports in the container request, the code previously checked the Docker type
image.ContainerConfig. There are recent errors in the GH actions regarding this: exposed ports being moved fromimage.ContainerConfigtoimage.Config, because it has been deprecated and depending on how the images were built it could be the case that theContainerConfigfield comes empty (e.g. images built with buildkit).Related issues
ContainerandContainerConfigfor/images/{id}/jsonmoby/moby#46939