Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove docker.io from Ryuk image name #2046

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

mdelapenya
Copy link
Member

@mdelapenya mdelapenya commented Dec 22, 2023

What does this PR do?

It removes the docker.io/ prefix from the default Ryuk image, to adhere to the docs in https://golang.testcontainers.org/features/image_name_substitution/#automatically-modifying-docker-hub-image-names

Why is it important?

It will make Ryuk configurable with the TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX env var or the hub.image.name.prefix property,
allowing developers to put Ryuk on their own registries if/when needed.

Related issues

How to test this PR

Update the ~/.testcontainers.properties with:

hub.image.name.prefix=registry.mycompany.com/mirror

Then run a test in the project: because the prefix points to a non-existent registry, the test will fail because Ryuk cannot be found,
meaning that the prefix was applied to Ryuk.

It will make it configurable with the TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX
env var or the hub.image.name.prefix property
@mdelapenya mdelapenya requested a review from a team as a code owner December 22, 2023 06:57
@mdelapenya mdelapenya added the bug An issue with the library label Dec 22, 2023
@mdelapenya mdelapenya self-assigned this Dec 22, 2023
Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 98befe7
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/65853367d7cf6f00089c2f96
😎 Deploy Preview https://deploy-preview-2046--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya merged commit 1bac302 into testcontainers:main Dec 22, 2023
116 checks passed
@mdelapenya mdelapenya deleted the ryuk-prefix branch December 22, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot modify Ryuk image
1 participant