Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add etcd module #2788

Merged
merged 50 commits into from
Sep 30, 2024
Merged

feat: add etcd module #2788

merged 50 commits into from
Sep 30, 2024

Conversation

mdelapenya
Copy link
Member

@mdelapenya mdelapenya commented Sep 19, 2024

What does this PR do?

This PR adds a Go module for etcd, including clustering support. This module includes options to configure:

  • nodes in the cluster
  • cluster token
  • auto TLS for cluster-node communication I removed it because it was not critical and causing issues in tests

I followed https://etcd.io/docs/v3.5/op-guide/clustering/ to accomplish it.

The module exposes methods to talk to the the client and the peer endpoints.

Why is it important?

A new module for etcd, which could unblock adoption in other technologies (gofiber's etcd storage)

@mdelapenya mdelapenya requested a review from a team as a code owner September 19, 2024 17:26
@mdelapenya mdelapenya added the feature New functionality or new behaviors on the existing one label Sep 19, 2024
@mdelapenya mdelapenya self-assigned this Sep 19, 2024
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit bf67013
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/66fabb5dd6c9ec0008d68195
😎 Deploy Preview https://deploy-preview-2788--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eddumelendez eddumelendez changed the title feat: add etc module feat: add etcd module Sep 19, 2024
modules/etcd/cmd_test.go Outdated Show resolved Hide resolved
modules/etcd/etcd.go Outdated Show resolved Hide resolved
modules/etcd/options.go Outdated Show resolved Hide resolved
modules/etcd/options.go Outdated Show resolved Hide resolved
modules/etcd/etcd.go Outdated Show resolved Hide resolved
modules/etcd/etcd.go Outdated Show resolved Hide resolved
modules/etcd/etcd.go Outdated Show resolved Hide resolved
modules/etcd/options.go Show resolved Hide resolved
modules/etcd/etcd.go Outdated Show resolved Hide resolved
modules/etcd/etcd.go Outdated Show resolved Hide resolved
modules/etcd/etcd.go Outdated Show resolved Hide resolved
modules/etcd/options.go Show resolved Hide resolved
modules/etcd/etcd.go Outdated Show resolved Hide resolved
modules/etcd/etcd.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making some good progress, nice catch on the network clean up.

modules/etcd/etcd.go Outdated Show resolved Hide resolved
modules/etcd/etcd.go Show resolved Hide resolved
modules/etcd/etcd.go Outdated Show resolved Hide resolved
modules/etcd/etcd.go Outdated Show resolved Hide resolved
modules/etcd/etcd.go Outdated Show resolved Hide resolved
modules/etcd/etcd.go Outdated Show resolved Hide resolved
modules/etcd/etcd_unit_test.go Outdated Show resolved Hide resolved
modules/etcd/etcd_unit_test.go Show resolved Hide resolved
Copy link
Collaborator

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few little things then I think we're there.

modules/etcd/etcd.go Outdated Show resolved Hide resolved
modules/etcd/etcd.go Outdated Show resolved Hide resolved
modules/etcd/etcd.go Outdated Show resolved Hide resolved
modules/etcd/etcd.go Outdated Show resolved Hide resolved
modules/etcd/etcd.go Show resolved Hide resolved
modules/etcd/etcd.go Show resolved Hide resolved
stevenh
stevenh previously approved these changes Sep 30, 2024
Copy link
Collaborator

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make that one last change to the internal run call, but it's a nit so approving anyway if you want to do in a follow up.

Copy link
Collaborator

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdelapenya mdelapenya merged commit f954f6d into testcontainers:main Sep 30, 2024
118 checks passed
@mdelapenya mdelapenya deleted the etcd-module branch September 30, 2024 16:16
mdelapenya added a commit that referenced this pull request Oct 17, 2024
* main:
  chore: replace 'assert' with 'require' (#2827)
  chore: replace 'assert' with 'require' for critical checks (#2824)
  chore: bump ryuk to latest release (#2818)
  feat: add require for critical checks (#2812)
  chore(deps): bump release-drafter/release-drafter from 5.25.0 to 6.0.0 (#2805)
  feat: add etcd module (#2788)
  feat: add dynamodb-local module (#2799)
  fix(redpanda): wait for (#2794)
  fix(elasticsearch): wait for (#2724)
  chore: update dockercfg module (#2801)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or new behaviors on the existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants