chore(rabbitmq): refactor assertEntity in tests #2856
Merged
+33
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
added
chore
mdelapenya
previously approved these changes
Oct 29, 2024
mmorel-35
force-pushed
the
rabbitmq/require-entity
branch
from
7bdd5dc
to
33be02c
Compare
mmorel-35
commented
Oct 30, 2024
mmorel-35
force-pushed
the
rabbitmq/require-entity
branch
2 times, most recently
from
e33a102
to
2e57db1
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
rabbitmq/require-entity
branch
from
2e57db1
to
e07422a
Compare
mdelapenya
reviewed
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors assertions on entities in
rabbitmq_test.goThis applies the assertions in each function and mutualizes duplicated code
Related issues
Related to #2855 (comment)