Keep exposed ports order in ContainerDef (#7811)

Order is lost and break modules with multiple ports defined.
testcontainers · Nov 15, 2023 · 6d33055 · 6d33055
1 parent 1419510
commit 6d33055
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/core/src/main/java/org/testcontainers/containers/ContainerDef.java b/core/src/main/java/org/testcontainers/containers/ContainerDef.java
@@ -32,7 +32,7 @@ class ContainerDef {
     @Getter
     private RemoteDockerImage image;
 
-    Set<ExposedPort> exposedPorts = new HashSet<>();
+    Set<ExposedPort> exposedPorts = new LinkedHashSet<>();
 
     Set<PortBinding> portBindings = new HashSet<>();
 
@@ -150,7 +150,7 @@ protected void setImage(DockerImageName image) {
     }
 
     public Set<ExposedPort> getExposedPorts() {
-        return new HashSet<>(this.exposedPorts);
+        return new LinkedHashSet<>(this.exposedPorts);
     }
 
     protected void setExposedPorts(Set<ExposedPort> exposedPorts) {

diff --git a/core/src/main/java/org/testcontainers/containers/GenericContainer.java b/core/src/main/java/org/testcontainers/containers/GenericContainer.java
@@ -272,12 +272,19 @@ public void setImage(Future<String> image) {
 
     @Override
     public List<Integer> getExposedPorts() {
-        return this.containerDef.getExposedPorts().stream().map(ExposedPort::getPort).collect(Collectors.toList());
+        List<Integer> exposedPorts = new ArrayList<>();
+        for (ExposedPort exposedPort : this.containerDef.getExposedPorts()) {
+            exposedPorts.add(exposedPort.getPort());
+        }
+        return exposedPorts;
     }
 
     @Override
     public void setExposedPorts(List<Integer> exposedPorts) {
-        this.containerDef.setExposedPorts(exposedPorts.stream().map(ExposedPort::tcp).collect(Collectors.toSet()));
+        this.containerDef.exposedPorts.clear();
+        for (Integer exposedPort : exposedPorts) {
+            this.containerDef.addExposedTcpPort(exposedPort);
+        }
     }
 
     /**