Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.flv videos generated by testcontainers webdriver aren't scrollable #512

Closed
iirekm opened this issue Dec 6, 2017 · 9 comments · Fixed by testcontainers/vnc-recorder#4 or #3180
Closed

.flv videos generated by testcontainers webdriver aren't scrollable #512

iirekm opened this issue Dec 6, 2017 · 9 comments · Fixed by testcontainers/vnc-recorder#4 or #3180
Labels
good first issue modules/selenium resolution/acknowledged type/feature

Comments

@iirekm
Copy link

iirekm commented Dec 6, 2017

for now I fix them with: ffmpeg -i video.flv -c:v copy -c:a copy fixed.flv
@rnorth
Copy link
Member

rnorth commented Dec 7, 2017

Ah ok - this is useful. Perhaps we can create a new VNC recording container that uses this. Thanks very much for suggesting it.

@stale
Copy link

stale bot commented Oct 28, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Oct 28, 2018
@kiview
Copy link
Member

kiview commented Nov 5, 2018

This still seems valid.

@stale stale bot removed the stale label Nov 5, 2018
@stale stale bot removed the stale label Nov 5, 2018
rnorth pushed a commit that referenced this issue Dec 23, 2018
@dependabot @rnorth
Bump HikariCP-java6 from 2.3.8 to 2.3.13 in /modules/mariadb (#1064)
4f1d631 
Bumps [HikariCP-java6](https://github.com/brettwooldridge/HikariCP) from 2.3.8 to 2.3.13.
<details>
<summary>Changelog</summary>

*Sourced from [HikariCP-java6's changelog](https://github.com/brettwooldridge/HikariCP/blob/dev/CHANGES).*

> HikariCP Changes
> 
> Changes in 3.2.0
> 
>  * check connection closed condition before attempting to set network timeout to avoid spurios exceptions
>    in the log.
> 
>  * updated validation failure message to include recommendation to check maxLifetime value.
> 
>  * fixed 1141 do not throw SQLException when calling isClosed() or close() on a already closed unwrapped
>    Connection, as per JDBC specification.
> 
>  * fixed 1137 support changing user/password at runtime for DriverDataSource-wrapped driver connections.
> 
>  * fixed 1136 log loaded driver when using jdbcUrl.
> 
>  * pull 1135 extract sealed pool check into independent method.
> 
>  * fixed 1126 correct error in JavaDoc for HikariConfig.setInitializationFailTimeout().
> 
>  * fixed 1114 removed unreachable code.
> 
> Changes in 3.1.0
> 
>  * Add get/setCatalog() to HikariConfigMXBean, allowing the catalog to be changed at runtime.
>    The catalog should only be changed while the pool is suspended, and after evicting existing
>    connections via HikariPoolMXBean.softEvictConnections().
> 
> Changes in 3.0.0
> 
>  * Removed previously deprecated methods;
>      HikariConfig.copyState()
>      HikariConfig.getScheduledExecutorService()
>      HikariConfig.setScheduledExecutorService()
>      HikariConfig.isInitializationFailFast()
>      HikariConfig.setInitializationFailFast()
>      HikariConfig.isJdbc4ConnectionTest()
>      HikariConfig.setJdbc4ConnectionTest()
> 
>      HikariDataSource.copyState()
>      HikariDataSource.getScheduledExecutorService()
>      HikariDataSource.setScheduledExecutorService()
>      HikariDataSource.suspendPool()
>      HikariDataSource.resumePool()
>      HikariDataSource.shutdown()
>      HikariDataSource.isInitializationFailFast()
>      HikariDataSource.setInitializationFailFast()
>      HikariDataSource.isJdbc4ConnectionTest()
>      HikariDataSource.setJdbc4ConnectionTest()
> 
></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- [`390c569`](brettwooldridge/HikariCP@390c569) [maven-release-plugin] prepare release HikariCP-2.3.13
- [`e94d920`](brettwooldridge/HikariCP@e94d920) Fixes [#512](https://github-redirect.dependabot.com/brettwooldridge/HikariCP/issues/512) back port to 2.3.x stream.
- [`d5e496c`](brettwooldridge/HikariCP@d5e496c) [maven-release-plugin] prepare for next development iteration
- [`260ac29`](brettwooldridge/HikariCP@260ac29) [maven-release-plugin] prepare release HikariCP-2.3.12
- [`a312c5a`](brettwooldridge/HikariCP@a312c5a) Skip proxy generation during test runs
- [`f0ba4b7`](brettwooldridge/HikariCP@f0ba4b7) Fixed issue with new proxy class generation whereby Java 6 classes were gener...
- [`fe6eb41`](brettwooldridge/HikariCP@fe6eb41) [maven-release-plugin] prepare for next development iteration
- [`af5ba3b`](brettwooldridge/HikariCP@af5ba3b) [maven-release-plugin] prepare release HikariCP-2.3.11
- [`2c632e7`](brettwooldridge/HikariCP@2c632e7) Fixes major class version number for generated proxy classes.
- [`e2f1915`](brettwooldridge/HikariCP@e2f1915) [maven-release-plugin] prepare for next development iteration
- Additional commits viewable in [compare view](brettwooldridge/HikariCP@HikariCP-2.3.8...HikariCP-2.3.13)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=com.zaxxer:HikariCP-java6&package-manager=gradle&previous-version=2.3.8&new-version=2.3.13)](https://dependabot.com/compatibility-score.html?dependency-name=com.zaxxer:HikariCP-java6&package-manager=gradle&previous-version=2.3.8&new-version=2.3.13)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the `.dependabot/config.yml` file in this repo:
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
rnorth pushed a commit that referenced this issue Dec 23, 2018
@dependabot @rnorth
Bump HikariCP-java6 from 2.3.8 to 2.3.13 in /modules/postgresql (#1051)
9e24ec0 
Bumps [HikariCP-java6](https://github.com/brettwooldridge/HikariCP) from 2.3.8 to 2.3.13.
<details>
<summary>Changelog</summary>

*Sourced from [HikariCP-java6's changelog](https://github.com/brettwooldridge/HikariCP/blob/dev/CHANGES).*

> HikariCP Changes
> 
> Changes in 3.2.0
> 
>  * check connection closed condition before attempting to set network timeout to avoid spurios exceptions
>    in the log.
> 
>  * updated validation failure message to include recommendation to check maxLifetime value.
> 
>  * fixed 1141 do not throw SQLException when calling isClosed() or close() on a already closed unwrapped
>    Connection, as per JDBC specification.
> 
>  * fixed 1137 support changing user/password at runtime for DriverDataSource-wrapped driver connections.
> 
>  * fixed 1136 log loaded driver when using jdbcUrl.
> 
>  * pull 1135 extract sealed pool check into independent method.
> 
>  * fixed 1126 correct error in JavaDoc for HikariConfig.setInitializationFailTimeout().
> 
>  * fixed 1114 removed unreachable code.
> 
> Changes in 3.1.0
> 
>  * Add get/setCatalog() to HikariConfigMXBean, allowing the catalog to be changed at runtime.
>    The catalog should only be changed while the pool is suspended, and after evicting existing
>    connections via HikariPoolMXBean.softEvictConnections().
> 
> Changes in 3.0.0
> 
>  * Removed previously deprecated methods;
>      HikariConfig.copyState()
>      HikariConfig.getScheduledExecutorService()
>      HikariConfig.setScheduledExecutorService()
>      HikariConfig.isInitializationFailFast()
>      HikariConfig.setInitializationFailFast()
>      HikariConfig.isJdbc4ConnectionTest()
>      HikariConfig.setJdbc4ConnectionTest()
> 
>      HikariDataSource.copyState()
>      HikariDataSource.getScheduledExecutorService()
>      HikariDataSource.setScheduledExecutorService()
>      HikariDataSource.suspendPool()
>      HikariDataSource.resumePool()
>      HikariDataSource.shutdown()
>      HikariDataSource.isInitializationFailFast()
>      HikariDataSource.setInitializationFailFast()
>      HikariDataSource.isJdbc4ConnectionTest()
>      HikariDataSource.setJdbc4ConnectionTest()
> 
></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- [`390c569`](brettwooldridge/HikariCP@390c569) [maven-release-plugin] prepare release HikariCP-2.3.13
- [`e94d920`](brettwooldridge/HikariCP@e94d920) Fixes [#512](https://github-redirect.dependabot.com/brettwooldridge/HikariCP/issues/512) back port to 2.3.x stream.
- [`d5e496c`](brettwooldridge/HikariCP@d5e496c) [maven-release-plugin] prepare for next development iteration
- [`260ac29`](brettwooldridge/HikariCP@260ac29) [maven-release-plugin] prepare release HikariCP-2.3.12
- [`a312c5a`](brettwooldridge/HikariCP@a312c5a) Skip proxy generation during test runs
- [`f0ba4b7`](brettwooldridge/HikariCP@f0ba4b7) Fixed issue with new proxy class generation whereby Java 6 classes were gener...
- [`fe6eb41`](brettwooldridge/HikariCP@fe6eb41) [maven-release-plugin] prepare for next development iteration
- [`af5ba3b`](brettwooldridge/HikariCP@af5ba3b) [maven-release-plugin] prepare release HikariCP-2.3.11
- [`2c632e7`](brettwooldridge/HikariCP@2c632e7) Fixes major class version number for generated proxy classes.
- [`e2f1915`](brettwooldridge/HikariCP@e2f1915) [maven-release-plugin] prepare for next development iteration
- Additional commits viewable in [compare view](brettwooldridge/HikariCP@HikariCP-2.3.8...HikariCP-2.3.13)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=com.zaxxer:HikariCP-java6&package-manager=gradle&previous-version=2.3.8&new-version=2.3.13)](https://dependabot.com/compatibility-score.html?dependency-name=com.zaxxer:HikariCP-java6&package-manager=gradle&previous-version=2.3.8&new-version=2.3.13)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the `.dependabot/config.yml` file in this repo:
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
@leonard84
Copy link
Contributor

Yeah I also stumbled over this I'd suggest ffmpeg -i video.flv -movflags faststart video.mp4 which transcodes it to x264 resulting in a size reduction of 75%-90%, the -movflags faststart will make it streamable. Either add ffmpeg to the vnc recording container or use https://hub.docker.com/r/jrottenberg/ffmpeg/ 4.1-scratch

@leonard84 leonard84 mentioned this issue Feb 19, 2019
Open
@artjomka
Copy link
Contributor

Is this issue up for taking ? Could try to dig in into it

@leonard84
Copy link
Contributor

@artjomka well testcontainers/vnc-recorder#3 is marked with help wanted and if you fixed that, then this should be fixed as well.

oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Aug 30, 2020
@oussamabadr
Make recorder .flv videos scrollable (testcontainers#512)
8dd5622
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Aug 31, 2020
@oussamabadr
Make recorder .flv videos scrollable (testcontainers#512)
4fbd2fe
oussamabadr added a commit to oussamabadr/vnc-recorder that referenced this issue Aug 31, 2020
@oussamabadr
Add ffmpeg testcontainers/testcontainers-java#512
cebb7c6
oussamabadr added a commit to oussamabadr/vnc-recorder that referenced this issue Aug 31, 2020
@oussamabadr
Add ffmpeg to fix testcontainers/testcontainers-java#512
ec58824
@oussamabadr oussamabadr mentioned this issue Aug 31, 2020
Merged
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Sep 2, 2020
@oussamabadr
Make recorder .flv videos scrollable (testcontainers#512)
e307d8c
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Sep 2, 2020
@oussamabadr
Remove third party container + Refactoring (testcontainers#512)
a50d156
oussamabadr added a commit to oussamabadr/vnc-recorder that referenced this issue Sep 6, 2020
@oussamabadr
Add ffmpeg to fix testcontainers/testcontainers-java#512 + Upgrade De…
eb05f67 
…bian to 10.5
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Sep 6, 2020
@oussamabadr
Remove third party container + Refactoring (testcontainers#512)
7008dfd
oussamabadr added a commit to oussamabadr/vnc-recorder that referenced this issue Sep 20, 2020
@oussamabadr
Add ffmpeg to fix testcontainers/testcontainers-java#512 + Upgrade De…
6e73154 
…bian to 10.5
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Sep 20, 2020
@oussamabadr
Make recorder .flv videos scrollable (testcontainers#512)
8f4480b
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Sep 20, 2020
@oussamabadr
Remove third party container + Refactoring (testcontainers#512)
87f4a54
oussamabadr added a commit to oussamabadr/vnc-recorder that referenced this issue Sep 22, 2020
@oussamabadr
Add ffmpeg to fix testcontainers/testcontainers-java#512 + Upgrade De…
fc5aaa8 
…bian to 10.5
@rnorth
Copy link
Member

rnorth commented Sep 22, 2020

Published: https://hub.docker.com/layers/testcontainers/vnc-recorder/1.2.0/images/sha256-1e14fc21b1dd7c28978f82f90008e4a603cc62744631cd299d3f846a08821ea9?context=repo

oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Oct 10, 2020
@oussamabadr
Make recorder .flv videos scrollable (testcontainers#512)
eba3d8e
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Oct 10, 2020
@oussamabadr
Remove third party container + Refactoring (testcontainers#512)
bbe5c62
@AB-xdev AB-xdev mentioned this issue Oct 27, 2020
Closed
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Nov 15, 2020
@oussamabadr
Make recorder .flv videos scrollable (testcontainers#512)
8cd9a73
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Nov 15, 2020
@oussamabadr
Remove third party container + Refactoring (testcontainers#512)
e53d54a
@kiview kiview mentioned this issue Nov 16, 2020
Merged
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Dec 11, 2020
@oussamabadr
Make recorder .flv videos scrollable (testcontainers#512)
553fc2d
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Dec 11, 2020
@oussamabadr
Remove third party container + Refactoring (testcontainers#512)
d447ffb
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Dec 11, 2020
@oussamabadr
Add MP4 support for Recorded video + Make FLV default format (testcon…
8b78a9c 
…tainers#512)
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Dec 12, 2020
@oussamabadr
Backward compatibility for default Recording format + Add Null check (t…
f57fc24 
…estcontainers#512)
@AB-xdev
Copy link
Contributor

AB-xdev commented Jan 25, 2021

Any progress here?
The pr for this issue also fixes #3405

oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Jan 29, 2021
@oussamabadr
Make recorder .flv videos scrollable (testcontainers#512)
335e84e
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Jan 29, 2021
@oussamabadr
Remove third party container + Refactoring (testcontainers#512)
680c737
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Jan 29, 2021
@oussamabadr
Add MP4 support for Recorded video + Make FLV default format (testcon…
47c322f 
…tainers#512)
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Jan 29, 2021
@oussamabadr
Backward compatibility for default Recording format + Add Null check (t…
3757cfd 
…estcontainers#512)
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Feb 10, 2021
@oussamabadr
Make recorder .flv videos scrollable (testcontainers#512)
a1942be
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Feb 10, 2021
@oussamabadr
Remove third party container + Refactoring (testcontainers#512)
839b3ee
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Feb 10, 2021
@oussamabadr
Add MP4 support for Recorded video + Make FLV default format (testcon…
997d34a 
…tainers#512)
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Feb 10, 2021
@oussamabadr
Backward compatibility for default Recording format + Add Null check (t…
e093058 
…estcontainers#512)
oussamabadr added a commit to oussamabadr/testcontainers-java that referenced this issue Feb 10, 2021
@oussamabadr
Correct code format + Make video format non nullable (testcontainers#512
01554f0 
)
bsideup added a commit that referenced this issue Feb 10, 2021
@oussamabadr @kiview @bsideup
Make VNC recorded videos scrollable (#3180)
a6f91e3 
This PR adds a second video recording mode, MP4, which is easier to consume and is scrollable.

Fixes #512

Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
Co-authored-by: Sergei Egorov <segorov@vmware.com>
@leonard84 leonard84 mentioned this issue Feb 19, 2021
Merged
This was referenced Mar 13, 2021
Open
Merged
Closed
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue modules/selenium resolution/acknowledged type/feature
Projects
None yet
Milestone
No milestone
6 participants
@rnorth @iirekm @artjomka @leonard84 @kiview @AB-xdev