Allow setting database name when using JDBC URL

[manikmagar]

As mentioned here in documentation, when using JDBC URL to initialize database, name is ignored and defaulted to test. Some times it is required to specify the database name.

Please make JDBC drivers to honor the database name set in the URL.

For example, jdbc:tc:mysql://somename:someport/library?TC_INITSCRIPT=library_db.sql should initialize a database named library and not test.

[bopfermann]

+1

The only way I found around this issue was to create custom extensions of JdbcDatabaseContainer with the appropriate hard coded value.

In my case this was more or less a copy-paste of the source for MySQLContainer

Requires a custom
/META-INF/services/org.testcontainers.containers.JdbcDatabaseContainerProvider
with the fully qualified classname of your custom implementation.

[kiview]

Hey @bopfermann,
would you like to provide a PR implementing this feature request? 🙂

[manikmagar]

I think JDBCDatabaseContainerProvider should be modified here#L10 -

public abstract JdbcDatabaseContainer newInstance(String tag, String jdbcUrl);

So, when a new container instance is acquired here, a reference of JDBC URL can be passed to the provider.

Then container providers such as MySQLContainerProvider here can utilize details from the URL and instantiate database with given name/details.

That is what is in mind for solution, Does that make sense?

[kiview]

Sounds like the right approach, but would be an API breaking change. Would you like to submit a PR and we look into the consequences?

[manikmagar]

Yes, it breaks the API for container provider. Sure, let me give it a try and then we can verify the behavior. Thanks.

[manikmagar]

Thinking out loud, how about providing an overloaded signature for newInstance method? With that, those providers who don’t need to implement this can still retain current behavior. WDYT?

[kiview]

And this method could have a default implementation returning newInstance(tag)?

[manikmagar]

Added a PR #594 #617 for this implementation.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

[kiview]

Closed by #617