Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/with-volumes-from support #289

Merged
merged 2 commits into from
Feb 12, 2017
Merged

feature/with-volumes-from support #289

merged 2 commits into from
Feb 12, 2017

Conversation

peterbollen
Copy link

Implements #244

Is this still something that could be added?

@bsideup bsideup added this to the 1.1.9 milestone Feb 7, 2017
* @param mode the bind mode
* @return this
*/
SELF withVolumesFrom(String otherContainer, BindMode mode);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it should have an overloaded method with Container as a first parameter, the same as withLink

@rnorth
Copy link
Member

rnorth commented Feb 12, 2017

Looks good to me - will merge

@rnorth rnorth merged commit 9cefeb7 into testcontainers:master Feb 12, 2017
@peterbollen peterbollen deleted the feature/with-volumes-from branch February 12, 2017 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants