-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency upon internet URLs for selenium tests #3271
Conversation
protected static void doSimpleExplore(BrowserWebDriverContainer rule) { | ||
RemoteWebDriver driver = setupDriverFromRule(rule); | ||
driver.get("http://en.wikipedia.org/wiki/Randomness"); | ||
|
||
// Oh! The irony! | ||
assertTrue("Randomness' description has the word 'pattern'", driver.findElementByPartialLinkText("pattern").isDisplayed()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no real sense in having two ways to test that Selenium is working, so just removed this altogether.
/** | ||
* Created by rnorth on 30/01/2016. | ||
*/ | ||
public class FlakyContainerCreationTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was old and ignored anyway, so have just removed.
/** | ||
* @author richardnorth | ||
*/ | ||
public class LinkedContainerTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that all our tests will now use 'linked' (networked) containers, there's little point in having an explicit test for it that works another way.
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Using the new shiny https://hub.docker.com/r/testcontainers/helloworld image