Fix javadoc for stop method #6834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it clear `stop` actually kills the container in Docker terminology. Include details of how to gracefully _stop_ the container, or send other signals.
core/src/main/java/org/testcontainers/containers/GenericContainer.java
Outdated
Show resolved
Hide resolved
eddumelendez
changed the title
GenericContainer
|
Thanks for your contribution, @big-andy-coates ! I've proceed with the description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not necessarily a fix for #1000, but at least make it easier for people to discover how to gracefully stop a container and/or send it different signals.
If/when this is merged, I'll leave it up to the committers to choose if #1000 should be closed, or if there is still intent to change the API. If the latter, I'm happy to raise a PR if someone gives brief guidance as to what api would be acceptable...