Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate withSecretInVault #7576

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Deprecate withSecretInVault #7576

merged 1 commit into from
Sep 25, 2023

Conversation

eddumelendez
Copy link
Member

@eddumelendez eddumelendez commented Sep 25, 2023 •
edited
Loading

Use withInitCommand

It has been been confusing for users the use of withSecreInVault and withInitCommand, see #7532. In order to be aligned with consul module we are encouraging to use just withInitCommand.

@eddumelendez
Deprecate withSecretInVault
132e667 
Use `withInitCommand`
@eddumelendez eddumelendez requested a review from a team as a code owner September 25, 2023 15:49
@eddumelendez eddumelendez added this to the next milestone Sep 25, 2023
@eddumelendez eddumelendez added the type/deprecation Public APIs are being deprecated but not changed yet label Sep 25, 2023
@eddumelendez eddumelendez merged commit 5d0631f into main Sep 25, 2023
85 checks passed
@eddumelendez eddumelendez deleted the deprecate-withsecretinvault branch September 25, 2023 20:09
@valfirst valfirst mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
modules/vault type/deprecation Public APIs are being deprecated but not changed yet
Projects
None yet
Milestone
1.19.1
Development

Successfully merging this pull request may close these issues.
1 participant
@eddumelendez