Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cassandra module #776

Merged
merged 8 commits into from
Jul 10, 2018
Merged

Add Cassandra module #776

merged 8 commits into from
Jul 10, 2018

Conversation

bsideup
Copy link
Member

@bsideup bsideup commented Jul 10, 2018

Superseeds #525 by @AnkBurov

@bsideup bsideup added this to the next milestone Jul 10, 2018
return getCluster(this);
}

public static Cluster getCluster(ContainerState containerState) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this method need to be public?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the argument is ContainerState and not GenericContainer

@Override
protected Session createNewConnection() {
try {
return CassandraContainer.getCluster(container)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above, why not calling getCluster() on the container?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the answer :)

@kiview
Copy link
Member

kiview commented Jul 10, 2018

LGTM apart from this minor questions.

@bsideup bsideup merged commit e178313 into master Jul 10, 2018
@bsideup bsideup deleted the cassandra branch July 10, 2018 14:36
@bsideup
Copy link
Member Author

bsideup commented Jul 10, 2018

Finally merged :D Thanks @AnkBurov for your contribution!

@AnkBurov
Copy link
Contributor

Nice! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants