Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log exception on socket problems #8055

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Log exception on socket problems #8055

merged 2 commits into from
Oct 22, 2024

Conversation

ciis0
Copy link
Contributor

@ciis0 ciis0 commented Jan 5, 2024

Fixes #8054

Note that SLF4J (1.6.0+) allows the last format parameter to be an exception to be printed https://www.slf4j.org/faq.html#paramException

@ciis0
Log exception on socket problems
3c86431 
Fixes testcontainers#8054

Note that SLF4J (1.6.0+) allows the last format parameter to be an exception to be printed https://www.slf4j.org/faq.html#paramException
@ciis0 ciis0 requested a review from a team as a code owner January 5, 2024 11:18
@eddumelendez eddumelendez added this to the next milestone Oct 22, 2024
@eddumelendez eddumelendez merged commit f50e5c3 into testcontainers:main Oct 22, 2024
15 checks passed
@eddumelendez
Copy link
Member

Thanks for your contribution, @ciis0!

@eddumelendez eddumelendez mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
1.20.3
Development

Successfully merging this pull request may close these issues.

[Bug]: socket problems should not swallow exceptions
2 participants
@ciis0 @eddumelendez