Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getConnectionString javadoc #8129

Conversation

gabrielluciano
Copy link
Contributor

Fix getConnectionString javadoc in MongoDBContainer class. The javadoc states that this method points to a database, but as seen in the method implementation, it doesn't.

     /**
     * Gets a connection string url, unlike {@link #getReplicaSetUrl} this does not point to a
     * database
     * @return a connection url pointing to a mongodb instance
     */
    public String getConnectionString() {
        return String.format("mongodb://%s:%d", getHost(), getMappedPort(MongoDBContainerDef.MONGODB_INTERNAL_PORT));
    }

@eddumelendez eddumelendez added this to the next milestone Mar 15, 2024
@eddumelendez eddumelendez merged commit 13c2641 into testcontainers:main Mar 15, 2024
97 checks passed
@eddumelendez
Copy link
Member

Thanks for your contribution, @gabrielluciano !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants