Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method for getting Weaviate's gRPC port #8431

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Add method for getting Weaviate's gRPC port #8431

merged 1 commit into from
Mar 9, 2024

Conversation

antas-marcin
Copy link
Contributor

This PR adds a convenience getGrpcHostAddress() method to Weaviate module, to get the gRPC host.
It also updates module's test to reflect this change.

@antas-marcin antas-marcin requested a review from a team as a code owner March 8, 2024 18:31
@eddumelendez eddumelendez added this to the next milestone Mar 8, 2024
@eddumelendez eddumelendez merged commit 5bb9607 into testcontainers:main Mar 9, 2024
97 checks passed
@eddumelendez
Copy link
Member

Thanks for your contribution, @antas-marcin !

@antas-marcin antas-marcin deleted the weaviate-module-grpc-port-method branch March 11, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddumelendez eddumelendez eddumelendez approved these changes

Assignees
No one assigned
Labels
modules/weaviate type/enhancement
Projects
None yet
Milestone
1.19.8
Development

Successfully merging this pull request may close these issues.
2 participants
@antas-marcin @eddumelendez