feat: Change the class used by the Oracle database driver #8796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
are both drivers offered in the same jar? I think for compatibility reason we should do something like this |
|
@cdouillard do you mind updating the PR addressing my previous comment? |
|
Yes they are part of the same jar, i look at the following jars :
These three jars are the ones listed by Oracle : https://www.oracle.com/database/technologies/maven-central-guide.html. |
|
@eddumelendez , i just applied your suggestion. |
|
Thanks for your contribution, @cdouillard ! |
lizhou1111
pushed a commit
to lizhou1111/testcontainers-java
that referenced
this pull request
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HikariCP logs a Warning when using the oracle.jdbc.driver.OracleDriver class. The use of the oracle.jdbc.OracleDriver class is now recommended (see https://stackoverflow.com/questions/6202653/difference-between-oracle-jdbc-driver-classes/6202721#6202721).